Fix infinite recursion for dependency cycles

.changeset/chatty-ligers-count.md

@@ -0,0 +1,5 @@
+---
+"@open-pioneer/vite-plugin-pioneer": patch
+---
+
+Fix infinite recursion when packages depend on each other (dependency cycle).

packages/vite-plugin/src/codegenPlugin.test.ts

@@ -286,6 +286,26 @@ describe("codegen support", function () {
         expect(error.message).toMatch(/[email protected] at/);
         expect(error.message).toMatch(/[email protected] at/);
     });
+
+    it("supports dependency cycles", async function () {
+        // The important thing about this test is that it terminates!
+        // Dependency cycle:
+        //      test-app --> a --> b --> a
+        const rootDir = resolve(TEST_DATA_DIR, "codegen-packages-cycle");
+        const outDir = resolve(TEMP_DATA_DIR, "codegen-packages-cycle");
+
+        await runViteBuild({
+            outDir,
+            rootDir,
+            pluginOptions: {
+                apps: ["test-app"]
+            }
+        });
+
+        const appJs = readFileSync(join(outDir, "test-app.js"), "utf-8");
+        assert.include(appJs, `console.info("Service A");`);
+        assert.include(appJs, `console.info("Service B");`);
+    });
 });
 
 function findModuleContaining(dir: string, needle: string) {

packages/vite-plugin/src/metadata/MetadataRepository.ts

@@ -109,7 +109,9 @@ export class MetadataRepository {
 
         // Map to ensure that we don't return duplicates. Key: package name
         const packageMetadataByName = new Map<string, PackageMetadata>();
+        const packageSeenByDirectory = new Set<string>();
         packageMetadataByName.set(appPackageMetadata.name, appPackageMetadata);
+        packageSeenByDirectory.add(appPackageMetadata.directory);
 
         // Recursively visit all dependencies.
         // Detected metadata is placed into `packageMetadata`.
@@ -123,14 +125,24 @@ export class MetadataRepository {
                     dependency,
                     importedFrom
                 });
-                if (packageMetadata) {
-                    if (!packageMetadataByName.has(packageMetadata.name)) {
-                        packageMetadataByName.set(packageMetadata.name, packageMetadata);
-                    }
+                if (!packageMetadata) {
+                    return;
+                }
+
+                if (!packageMetadataByName.has(packageMetadata.name)) {
+                    packageMetadataByName.set(packageMetadata.name, packageMetadata);
+                }
+
+                if (!packageSeenByDirectory.has(packageMetadata.directory)) {
+                    packageSeenByDirectory.add(packageMetadata.directory);
+
                     await visitDependencies(
                         packageMetadata.dependencies,
                         packageMetadata.packageJsonPath
                     );
+                } else {
+                    isDebug &&
+                        debug(`Skipping already visited package at %s`, packageMetadata.directory);
                 }
             });
             return await Promise.all(jobs);

packages/vite-plugin/test-data/codegen-packages-cycle/apps/test-app/app.js

@@ -0,0 +1,2 @@
+import { packages } from "open-pioneer:app";
+console.log(packages);

packages/vite-plugin/test-data/codegen-packages-cycle/apps/test-app/build.config.mjs

@@ -0,0 +1 @@
+export default {};

packages/vite-plugin/test-data/codegen-packages-cycle/apps/test-app/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "test-app",
+    "private": true,
+    "dependencies": {
+        "a": "1.0.0"
+    }
+}

packages/vite-plugin/test-data/codegen-packages-cycle/packages/a/build.config.mjs

@@ -0,0 +1,11 @@
+export default {
+    services: {
+        Service: {
+            provides: [
+                {
+                    name: "a.Service"
+                }
+            ]
+        }
+    },
+};

packages/vite-plugin/test-data/codegen-packages-cycle/packages/a/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "a",
+    "version": "1.0.0",
+    "dependencies": {
+        "b": "1.0.0"
+    }
+}

packages/vite-plugin/test-data/codegen-packages-cycle/packages/a/services.ts

@@ -0,0 +1,5 @@
+export class Service {
+    constructor() {
+        console.info("Service A");
+    }
+}

packages/vite-plugin/test-data/codegen-packages-cycle/packages/b/build.config.mjs

@@ -0,0 +1,11 @@
+export default {
+    services: {
+        Service: {
+            provides: [
+                {
+                    name: "b.Service"
+                }
+            ]
+        }
+    },
+};

packages/vite-plugin/test-data/codegen-packages-cycle/packages/b/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "b",
+    "version": "1.0.0",
+    "dependencies": {
+        "a": "1.0.0"
+    }
+}

packages/vite-plugin/test-data/codegen-packages-cycle/packages/b/services.ts

@@ -0,0 +1,5 @@
+export class Service {
+    constructor() {
+        console.info("Service B");
+    }
+}