sharedfp_sm_file_component_query: add file open to ensure correct ope… #9784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlauria
reviewed
Dec 21, 2021
ompi/mca/sharedfp/sm/sharedfp_sm.c
Outdated
| char *filename_basename = basename((char*)fh->f_filename); | ||
|
|
||
| /* format is "%s/%s_cid-%d-%d.sm", see below */ | ||
| int sm_filename_length = strlen(ompi_process_info.job_session_dir) + 1 + strlen(filename_basename) + 5 + (3*sizeof(uint32_t)+1) + 4; |
There was a problem hiding this comment.
Maybe just use asprintf()?
There was a problem hiding this comment.
you are right, thanks! This simplifies the code a bit.
…rations try to actually open the sharedfp/sm file during the query operation to ensure that the component can actually run. This is based on some reports on the mailing list that the sharedfp/sm operation causes problems in certain circumstances. Fixes issue open-mpi#9656 Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
topic/sharedfp-sm-init
branch
from
5e6b71a to
d8464d2
Compare
awlauria
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rations
try to actually open the sharedfp/sm file during the query operation to ensure
that the component can actually run. This is based on some reports on the mailing list that
the sharedfp/sm operation causes problems in certain circumstances.
Fixes issue #9656
Signed-off-by: Edgar Gabriel [email protected]