Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha/mpi4py: Re-enable multi proc runs #12357

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

dalcinl
Copy link
Contributor

@dalcinl dalcinl commented Feb 21, 2024

No description provided.

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

d27ce4e: gha/mpi4py: Re-enable multi proc runs

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@dalcinl
Copy link
Contributor Author

dalcinl commented Feb 26, 2024

@jsquyres Could you please help me get this one moving forward?

Question: Is there any way (configure option?) to disable build/install of documentation, manual pages, etc. ?

@hppritcha
Copy link
Member

@jsquyres Could you please help me get this one moving forward?

Question: Is there any way (configure option?) to disable build/install of documentation, manual pages, etc. ?

the --disable-sphinx should stop attempting to generate docs

@dalcinl
Copy link
Contributor Author

dalcinl commented Feb 27, 2024

the --disable-sphinx should stop attempting to generate docswith release tarballs

Yes... but I still see manual pages being installed in make install. I'm just trying to figure out whether that step can be avoided to save time when building on an emulated architecture under Docker (something that we are not yet doing here, but I'm doing elsewhere with release tarballs to generate binary package for Python consumption).

Anyway, disabling man pages installations is not really a big deal right now.
I think everything is fine now and we should try to get this one merged ASAP.

@hppritcha hppritcha merged commit 4847e41 into open-mpi:main Feb 27, 2024
11 checks passed
@dalcinl dalcinl deleted the mpi4py branch April 19, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants