-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Bump prrte and openpmix to latest release tags" #12335
Conversation
This reverts commit f06b1d9. Signed-off-by: Wenduo Wang <[email protected]>
Just to be clear: the above statement is inaccurate. "Debug mode" simply exposed the bug - it didn't cause it. Without the FWIW: the problem change is in PMIx v4.2.7 and above, so this has been around for awhile - and undetected until we re-enabled the devel-check by default code. |
@rhc54 Thanks a lot for the quick fix. I don't think it's a bug in pmix but unfortunately fixing the bug caused a surprise. I don't imagine there will be a 4.2.10 release - so I'm inclined to pin pmix to 4.2.8 for the moment. Also I just realized that openpmix also requires min hwloc 1.11 https://docs.openpmix.org/en/latest/installing-pmix/required-support-libraries.html |
It actually is a bug in PMIx, and it goes all the way back to the v4.2.7 release. You'd have to back down to v4.2.6 to get away from it. Only reason you haven't been impacted is because you are ignoring the warnings being emitted during build - and the change in v4.2.9 forced those warnings to be treated as errors (thereby stopping the build) when building from a Git clone. There will be no 4.2.10 release - ever. You can either default to v4.2.6 or move up to v5.0.2 (soon to be released). Or just don't care about the potential errors and release with v4.2.8 - and let your users live with any resulting problems. I'll warn folks from over here about using OMPI v5.x in that case and recommend building against an external correct PMIx instead. |
@rhc54 Curious is this issue also on pmix 5.0? I'm planning to test out the integration in a PR soon. |
No, I just backported the fix to it this morning 😄 |
The NVIDIA CI failure is a failure in their CI during setup. The mpi4py failure is (I believe) a known problem that @hppritcha is working on - hard for me to do anything about it when some unknown test simply says "it didn't work". |
revert so that CI's can pass, then we'll bump |
This reverts commit f06b1d9.
The new openpmix breaks compatibility with hwloc 1.11 in debug mode. Temporarily reverting the change.