Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opal/accelerator: allow 0 size copies - v5.0.x #12241

Merged

Conversation

edgargabriel
Copy link
Member

@edgargabriel edgargabriel commented Jan 17, 2024

it looks like zero size messages with valid buffer pointers are triggered for send-to-self operations and with persistent request even for message sizes > 0. The current accelerator components return however an error for size 0 making those tests fail in our testsuite.

This commit allows size 0 messages, and returns immediately.

Signed-off-by: Edgar Gabriel [email protected]
(cherry picked from commit 9965f6c)

it looks like zero size messages with valid buffer pointers can occur
for send-to-self operations and with persistent request. The current
accelerator components return however an error for size 0 making those
tests fail in our testsuite.

This commit allows size 0 messages, and returns immediatly.

Signed-off-by: Edgar Gabriel <[email protected]>
(cherry picked from commit 9965f6c)
@github-actions github-actions bot added this to the v5.0.2 milestone Jan 17, 2024
@wenduwan
Copy link
Contributor

Tested on main, now running AWS internal CI for 5.0.x

Copy link
Contributor

@wenduwan wenduwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed AWS CI

@edgargabriel edgargabriel changed the title opal/accelerator: allow 0 size copies opal/accelerator: allow 0 size copies - v5.0.x Jan 19, 2024
@janjust janjust merged commit 9149483 into open-mpi:v5.0.x Jan 19, 2024
22 checks passed
@edgargabriel edgargabriel deleted the pr/accelerator-size-0-fix-v5.0.x branch July 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants