move include of sys/mount back to where it was(restart ci) #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the sys/mount.h can be tricky to use because various other system include files sometimes redefine some of the symbols in this include file, leading to compile failures. Careful ordering of include files may solve the problem, but here it simpler just to move the include of sys/mount.h back to its original location. related to open-mpi#12181 Signed-off-by: Howard Pritchard <[email protected]>
edgargabriel
approved these changes
Dec 21, 2023
|
we will have to backport this to 5.0, since the same fix has already been merged to 5.0 as well. I can update the pr to the 4.1 branch, since that is not yet merged |
wenduwan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the sys/mount.h can be tricky to use
because various other system include files sometimes redefine some of the symbols in this include file, leading
to compile failures.
Careful ordering of include files may solve the problem, but here it simpler just to move the include of sys/mount.h back to its original location.
related to #12181