Fix multithread request wait #11966
Closed
Fix multithread request wait #11966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Germain <[email protected]>
devreal
reviewed
Oct 4, 2023
| @@ -447,53 +447,84 @@ static inline bool ompi_request_tag_is_collective(int tag) { | |||
| * Wait a particular request for completion | |||
| */ | |||
|
|
|||
| static inline void ompi_request_wait_completion(ompi_request_t *req) | |||
| static inline void ompi_request_wait_completion(ompi_request_t **req) | |||
There was a problem hiding this comment.
Why is this change necessary? Are we assigning anything to that pointer? (maybe I'm missing something here)
There was a problem hiding this comment.
the change is to handle the case where another thread switch the request to MPI_REQUEST_NULL
As concurrent wait on the same request is erroneous, this shouldn't happen
|
issue relates to an erroneous behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11965
Fix: multi-thread logic issue in ompi/request/request.h:ompi_request_wait_completion
Fix: ensure request free is only called once on each request in ompi/request/req_wait.c:ompi_request_default_wait
The wait fix must be done in waitany, waitsome, waitall, test, testany, testsome, testall to ensure request free is only called once.
If the wait change suits you, then I can apply it to the other functions.