Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CustomTracer originally failed to trace Tensor object #655

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MR-hyj
Copy link

@MR-hyj MR-hyj commented Nov 16, 2024

fix the problem that the static graph of a model fails to trace any tensor constants within.

Motivation

During QAT training, the model being trained contains some tensor constants, such as reg_max=torch.arange(16). These constants are also stored within the model. However, the following logic fails to include these tensors, resulting in a mismatch between the static graph and the actual model during subsequent training.

image

Modification

elif is added to support tensor objects, as shown in line 147 and 148

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • [❌] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [✅] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [✅] The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • [❌] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant