[Features] : add flow1d correlation and correlation lookup #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.10% // Head: 70.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 69.10% 70.27% +1.17%
==========================================
Files 93 96 +3
Lines 5195 5467 +272
Branches 741 720 -21
==========================================
+ Hits 3590 3842 +252
- Misses 1491 1500 +9
- Partials 114 125 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MeowZheng
reviewed
Aug 15, 2022
mmflow/models/utils/correlation1d.py
Outdated
| self, | ||
| feat1: Tensor, | ||
| feat2_x: Tensor, | ||
| feat2_y: Tensor, |
There was a problem hiding this comment.
Suggested change
| feat2_y: Tensor, | |
| feat2_y: Tensor |
MeowZheng
reviewed
Aug 15, 2022
MeowZheng
reviewed
Aug 15, 2022
mmflow/models/utils/correlation1d.py
Outdated
Comment on lines
87
to
89
| corr = corr.permute(0, 2, 1, 3).contiguous().view(b, h, w, 1, h, 1) | ||
| corr = corr / scale_factor | ||
| corr = corr.flatten(0, 2) |
There was a problem hiding this comment.
Suggested change
| corr = corr.permute(0, 2, 1, 3).contiguous().view(b, h, w, 1, h, 1) | |
| corr = corr / scale_factor | |
| corr = corr.flatten(0, 2) | |
| corr = corr.view(-1, 1, h, 1) / scale_factor |
MeowZheng
reviewed
Aug 18, 2022
mmflow/ops/corr_lookup.py
Outdated
| concatenate together. | ||
| """ | ||
| B, _, H, W = flow.shape | ||
| # reshape corr_x to [B*H*W, 1, 1, W] |
There was a problem hiding this comment.
Suggested change
| # reshape corr_x to [B*H*W, 1, 1, W] | |
| # reshape corr_x from [B, H, W, W] to [B*H*W, 1, 1, W] |
Fc-idris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add correlation and correlation lookup of flow1d.
Modification
correlation1d compute the correlation of feature1 and cross attention on x or y direction
correlation lookup serach on 2r+1 width or height space,