Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code for parallel preprocessing #270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mboyanov
Copy link

@mboyanov mboyanov commented Sep 5, 2024

✨ Description

I am working towards applying this model on a custom dataset and the preprocessing was rather slow. I noticed that there was no multiprocessing during the extraction of the acoustic features, so I added it in.

🚧 Related Issues

[List the issue numbers related to this PR]

👨‍💻 Changes Proposed

  • use ProcessPoolExecutor when calculating acoustic features
  • ...

🧑‍🤝‍🧑 Who Can Review?

[Please use the '@' symbol to mention any community member who is free to review the PR once the tests have passed. Feel free to tag members or contributors who might be interested in your PR.]

🛠 TODO

  • task1
  • ...

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@RMSnow RMSnow requested a review from Adorable-Qin September 19, 2024 14:53
@mboyanov
Copy link
Author

Hey @Adorable-Qin I reformatted the code using the black tool. Could you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant