Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare Release 1.4.8 #253

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat: Prepare Release 1.4.8 #253

merged 2 commits into from
Aug 21, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Aug 21, 2024

Preparing the Release 1.4.8 by doing the following:

  • Update versions to 1.4.8
  • Add spPrivateKey to values.yaml as a secret
  • Add spPrivateKey logic to _helpers.tpl
  • Add validateXml to values.yaml as Boolean
  • Add validateXml to secrets.yaml template
  • Remove wantNameIdEncrypted from secrets.yaml
  • Remove logic involving wantNameIdEncrypted from _helpers.tpl
  • Update values.schema.json accordingly

These decisions were taken based on the following git diff
image

Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@akash-jain-10 akash-jain-10 changed the title Prepare Release 1.4.8 feat: Prepare Release 1.4.8 Aug 21, 2024
@IceS2 IceS2 merged commit e834284 into main Aug 21, 2024
1 check passed
@IceS2 IceS2 deleted the feat/prepare-release-1-4-8 branch August 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants