Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Indentation issue for envFrom helm values #228

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Indentation issue for envFrom helm values #228

merged 1 commit into from
Apr 8, 2024

Conversation

akash-jain-10
Copy link
Collaborator

What this PR does / why we need it :

Fixes #227

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@akash-jain-10 akash-jain-10 requested a review from tutte April 8, 2024 07:37
@akash-jain-10 akash-jain-10 self-assigned this Apr 8, 2024
tutte
tutte approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akash-jain-10 akash-jain-10 merged commit 7e241c9 into main Apr 8, 2024
1 check failed
@akash-jain-10 akash-jain-10 deleted the fix/env-from-indentation-issue branch April 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

Assignees

@akash-jain-10 akash-jain-10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart Indentation issue when using envFrom values
2 participants
@akash-jain-10 @tutte