Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #222 #224

Merged
merged 7 commits into from
Apr 8, 2024
Merged

fix: #222 #224

merged 7 commits into from
Apr 8, 2024

Conversation

akash-jain-10
Copy link
Collaborator

@akash-jain-10 akash-jain-10 commented Mar 13, 2024

What this PR does / why we need it :

Fixes #222

To test the above changes, run the below commands -

cd charts/openmetadata
helm template om . --values values.yaml --set openmetadata.config.secretsManager.provider=managed-azure-kv --set openmetadata.config.secretsManager.additionalParameters.enabled=true
cd charts/openmetadata
helm template om . --values values.yaml --set openmetadata.config.secretsManager.provider=managed-aws --set openmetadata.config.secretsManager.additionalParameters.enabled=true

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@Nemeczek
Copy link

Hey, quick question. in the docs there is option to do "If only the , parameter is provided, we will use Azure's default Authentication Credential." in the Airflow part. I saw that in the OM Server there is support for DefaultAzureCredential as well. So will be able, after this PR is merged, to do either/both of ServicePrincipal with ClientId and Secret or using ManagedIndeity by providing only KV name on both server and airflow?

Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@akash-jain-10 akash-jain-10 merged commit 83b837d into main Apr 8, 2024
1 check passed
@akash-jain-10 akash-jain-10 deleted the fix-issue-222 branch April 8, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Secrets Manager not supported by the chart
4 participants