Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update teams dropdown for admin #19797

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Fix: Update teams dropdown for admin #19797

merged 6 commits into from
Feb 14, 2025

Conversation

sweta1308
Copy link
Contributor

@sweta1308 sweta1308 commented Feb 14, 2025 •
edited
Loading

Before:
All the teams were not visible for admin.

Screen-Recording.3.mp4

After:
Admin can access all the teams to edit in profile page.

Screen-Recording.2.mp4

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sweta1308 sweta1308 requested a review from a team as a code owner February 14, 2025 07:01
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@sweta1308 sweta1308 added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Feb 14, 2025
@sweta1308 sweta1308 added the To release Will cherry-pick this PR into the release branch label Feb 14, 2025
chirag-madlani
chirag-madlani reviewed Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sweta1308 add playwright tests please

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (41374/64020) 40.98% (16710/40780) 44.22% (5041/11401)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sweta1308 sweta1308 merged commit 165af4a into open-metadata:main Feb 14, 2025
15 of 17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.4 branch.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
@sweta1308
Fix: Update teams dropdown for admin (#19797)
7799023 
* update teams dropdown for admin

* add test for team edit

* fix sonar issue

* update sort method

* update sort function

* fix sonar

(cherry picked from commit 165af4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweta1308 @chirag-madlani