Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: powerbi fetch workspaces failure handle #19785

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

MINOR: powerbi fetch workspaces failure handle #19785

wants to merge 7 commits into from
+85 −14

Conversation

harshsoni2024
Copy link
Contributor

@harshsoni2024 harshsoni2024 commented Feb 13, 2025 •
edited
Loading

Describe your changes:

Fixes #19795

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshsoni2024 harshsoni2024 requested a review from a team as a code owner February 13, 2025 13:43
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@harshsoni2024 harshsoni2024 changed the title MINOR: powerbi workspace api fix MINOR: powerbi fetch workspaces failure handle Feb 14, 2025
pmbrull
pmbrull reviewed Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's configure the pagination in the service

ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py Outdated
count = response.odata_count
entities_per_page = self.pagination_entity_per_page
failed_indexes = []
params_data = {"$top": "1", "$skip": "0"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this dict is static let's make it a constant

ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py Outdated
response = self.client.get(api_url, data=params_data)
if (
not response
or "message" in response
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"message" string could be a constant too

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull left review comments

@ulixius9 ulixius9 ulixius9 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

powerbi fetch workspaces failure handle
3 participants
@harshsoni2024 @pmbrull @ulixius9