Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove default 100 when profileSample is None #19672

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 4, 2025

Describe your changes:

  • Remove default fallback whenprofileSample is None

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

sushi30
sushi30 previously approved these changes Feb 4, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

@TeddyCr TeddyCr merged commit 28bd01c into open-metadata:main Feb 5, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants