Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): handle 401 for wrong password case #19662

Merged
merged 9 commits into from
Feb 10, 2025
Merged

fix(ui): handle 401 for wrong password case #19662

merged 9 commits into from
Feb 10, 2025
+16 −12

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Feb 4, 2025 •
edited
Loading

Describe your changes:

Fixes: Forever loading for invalid password

Issue

Screen.Recording.2025-02-04.at.2.55.42.PM.mov

Fix

Screen.Recording.2025-02-04.at.3.03.16.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani chirag-madlani requested a review from a team as a code owner February 4, 2025 09:34
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Feb 4, 2025
aniketkatkar97
aniketkatkar97 previously approved these changes Feb 4, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.6% (41316/63955) 40.98% (16697/40743) 44.19% (5029/11380)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 5bb8c5c into main Feb 10, 2025
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the fix-login-401 branch February 10, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @aniketkatkar97