Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix mssql integration test #17923

Merged
merged 7 commits into from
Sep 20, 2024
Merged

MINOR: fix mssql integration test #17923

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97aa9d5
change tag for sql server due to https://github.com/microsoft/mssql-d…
sushi30 Sep 19, 2024
85a186c
use 2022-latest
sushi30 Sep 19, 2024
604834d
fixed mssql tests
sushi30 Sep 19, 2024
7b2fa3f
format
sushi30 Sep 19, 2024
68715c1
used new columns
sushi30 Sep 19, 2024
ca37eb6
use the custom sql server
sushi30 Sep 20, 2024
ac1f903
Merge branch 'main' into fix-mssql-ci
sushi30 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ingestion/tests/integration/sql_server/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
@pytest.fixture(scope="module")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a question on my end. Wouldn't scope=module make it so the fixture would be destroyed at the end of the last test in sql_server/test_lineage.py for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. With containers a best practice is to have session (since its most expensive to setup) level fixtures for the containers and module level fixtures for data entities like databases or tables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for this case the data stays static throughout the tests so its fine like this.

def mssql_container(tmp_path_factory):
container = SqlServerContainer(
"mcr.microsoft.com/mssql/server:2017-latest", dbname="AdventureWorks"
"mcr.microsoft.com/mssql/server:2017-CU31-GDR2-ubuntu-18.04", dbname="AdventureWorks"
)
data_dir = tmp_path_factory.mktemp("data")
shutil.copy(
Expand Down
Loading