Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mylife: smoother mysubmission (fixes #5091) #5126

Merged
merged 6 commits into from
Jan 29, 2025
Merged

mylife: smoother mysubmission (fixes #5091) #5126

merged 6 commits into from
Jan 29, 2025

Conversation

Avinash-Codes
Copy link
Member

fixes #5091

@huitk
Copy link
Member

huitk commented Jan 24, 2025

The circle is gone but when I click mySurvey, it is still direct us to mySubmission.
Screenshot 2025-01-24 at 3 34 49 PM

Okuro3499
Okuro3499 requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment •
edited by Avinash-Codes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for an empty survey page I get no exam submissions instead of no survey submissions also update the page title shows mysubmissions

Screen_recording_20250127_163626.webm

@Okuro3499
Copy link
Collaborator

@Avinash-Codes also do a rebase a master merge will overwrite your changes

Okuro3499
Okuro3499 requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mySubmission now shows mysurveys
Screen_recording_20250127_223211.webm

app/src/main/java/org/ole/planet/myplanet/base/BaseRecyclerFragment.kt Outdated
@@ -5,6 +5,7 @@ import android.content.SharedPreferences
import android.os.Build
import android.os.Bundle
import android.text.TextUtils
import android.util.Log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup log

Copy link
Collaborator

@Okuro3499 Okuro3499 Jan 27, 2025 •
edited by Avinash-Codes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mySubmission now shows mysurveys

Screen_recording_20250127_223211.webm

@huitk huitk self-requested a review January 27, 2025 21:29
@Okuro3499 Okuro3499 requested review from deeppp15 and pavi38 January 29, 2025 16:01
@dogi dogi changed the title mySubmission: smoother ui (fixes #5091) mylife: smoother mysubmission (fixes #5091) Jan 29, 2025
@dogi dogi merged commit 3649a36 into master Jan 29, 2025
2 checks passed
pavi38 pushed a commit that referenced this pull request Jan 31, 2025
@Avinash-Codes @Okuro3499
@dogi @pavi38
mylife: smoother mysubmission (fixes #5091) (#5126)
5a4f2a7 
Co-authored-by: Gideon Okuro <[email protected]>
Co-authored-by: dogi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@huitk huitk huitk approved these changes

@dogi dogi dogi approved these changes

@deeppp15 deeppp15 Awaiting requested review from deeppp15

@pavi38 pavi38 Awaiting requested review from pavi38

Assignees
No one assigned
Labels
peer review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysurvey title
4 participants
@Avinash-Codes @huitk @Okuro3499 @dogi