Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat: smoother provider selection (fixes #5067) #5068

Merged

Conversation

Avinash-Codes
Copy link
Member

fixes #5067

image

@Avinash-Codes Avinash-Codes linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link
Member

@deeppp15 deeppp15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Initial view of chat still looks like he old version
chat.selection.webm

Copy link
Member

@pavi38 pavi38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency in the size of the highlighted button. Initially the highlighted button is larger than others but later on the size of the highlighted button remain similar as other buttons.

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avinash-Codes the button sizes updated to be the same size is ok but leave them on the right side for consistency with planet on the placement
Screenshot 2025-01-20 at 14 53 38

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avinash-Codes when first time you open the chat the buttons are not same size until you click

Screen_recording_20250121_213348.mp4

@Okuro3499 Okuro3499 requested a review from huitk January 24, 2025 10:58
@dogi dogi changed the title chat: smoother UI (fixes #5067) chat: smoother provider selection (fixes #5067) Jan 27, 2025
@dogi dogi merged commit 5649c4c into master Jan 27, 2025
2 checks passed
@Okuro3499 Okuro3499 deleted the 5067-centering-the-model-selection-in-chat-sectionbetter-ui branch January 28, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centering the model selection in chat section(better ui)
6 participants