Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enterprises: smoother finances filter (fixes #5007)(fixes #5079) #5036

Merged
merged 13 commits into from
Jan 28, 2025

Conversation

deeppp15
Copy link
Member

@deeppp15 deeppp15 commented Jan 15, 2025

Desciption

Screenshot

working.filter.dark.mode.webm
working.filter.light.mode.webm

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datePicker dialog already has a date from and date to

Screen_recording_20250115_171950.webm

Copy link
Member

@Avinash-Codes Avinash-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datePicker dialog already includes a "From" date and a "To" date, so there's no need to specify "From date" and "To date" again.

@deeppp15
Copy link
Member Author

@okuro @Avinash-Codes , previously date ranges were not visible. Now they can be visible while filtering the fincances

@Okuro3499
Copy link
Collaborator

@okuro @Avinash-Codes , previously date ranges were not visible. Now they can be visible while filtering the fincances

yeah maybe what you needed to add was textviews for the date ranges and not other datepickers

@deeppp15
Copy link
Member Author

Hi @Okuro3499 @Avinash-Codes please review the below updates made to the date picker

finances.updated.webm

@Avinash-Codes
Copy link
Member

@deeppp15 Things are working fine, but there are a few issues. After selecting the "from date" and "to date," the date filter disappears. Wouldn't it be better if it remained visible so that users could change or reset the filter without having to go back?

What do you think, @Okuro3499 ?

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no finance data within selected period is found everything disappears
Screen_recording_20250121_214058.webm

@deeppp15 deeppp15 requested a review from Okuro3499 January 21, 2025 23:50
@deeppp15
Copy link
Member Author

Hi Okuro, please check
date filter.webm

@deeppp15 deeppp15 changed the title finances: smoother filter (fixes #5007) finances: smoother filter (fixes #5007 #5079) Jan 21, 2025
@Okuro3499 Okuro3499 requested review from pavi38 and huitk January 22, 2025 10:47
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeppp15 filter now works ok just I have an empty list but there is a total value also add a placeholder for empty list a function for this showNoData already exists in the BaseRecyclerFragment
Screen_recording_20250122_134448.webm

@deeppp15
Copy link
Member Author

Hi @Okuro3499 , please check now
image

@deeppp15 deeppp15 requested a review from Okuro3499 January 22, 2025 21:20
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the total should be the total value of the list so an empty list should show 0
imageedit_2_5170648609

@deeppp15
Copy link
Member Author

Hi @Okuro3499

image

@deeppp15 deeppp15 requested a review from Okuro3499 January 24, 2025 21:01
@huitk
Copy link
Member

huitk commented Jan 24, 2025

It works on my emulator. The empty list is already changed to 0.
Screenshot 2025-01-24 at 4 39 47 PM

@dogi dogi changed the title finances: smoother filter (fixes #5007 #5079) enterprises: smoother filter (fixes #5007)(fixes #5079) Jan 28, 2025
@dogi dogi changed the title enterprises: smoother filter (fixes #5007)(fixes #5079) enterprises: smoother finances filter (fixes #5007)(fixes #5079) Jan 28, 2025
@dogi dogi merged commit 743077e into master Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants