-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enterprises: smoother finances filter (fixes #5007)(fixes #5079) #5036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datePicker dialog already has a date from and date to
Screen_recording_20250115_171950.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The datePicker dialog already includes a "From" date and a "To" date, so there's no need to specify "From date" and "To date" again.
@okuro @Avinash-Codes , previously date ranges were not visible. Now they can be visible while filtering the fincances |
yeah maybe what you needed to add was textviews for the date ranges and not other datepickers |
Hi @Okuro3499 @Avinash-Codes please review the below updates made to the date picker finances.updated.webm |
@deeppp15 Things are working fine, but there are a few issues. After selecting the "from date" and "to date," the date filter disappears. Wouldn't it be better if it remained visible so that users could change or reset the filter without having to go back? What do you think, @Okuro3499 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if no finance data within selected period is found everything disappears
Screen_recording_20250121_214058.webm
Hi Okuro, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deeppp15 filter now works ok just I have an empty list but there is a total value also add a placeholder for empty list a function for this showNoData
already exists in the BaseRecyclerFragment
Screen_recording_20250122_134448.webm
Hi @Okuro3499 , please check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Okuro3499 |
Desciption
Screenshot
working.filter.dark.mode.webm
working.filter.light.mode.webm