Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ctrl by Ctrl_internal in the screen model #1369

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Replace Ctrl by Ctrl_internal in the screen model #1369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1437da
Replace Ctrl by Ctrl_internal in the screen model to avoid warnings o…
jelgerjansen Jul 26, 2024
1b6fe41
Merge branch 'master' into issue1367_ShadingConditional
lucasverleyen Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions IDEAS/Buildings/Components/Shading/Screen.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ within IDEAS.Buildings.Components.Shading;
model Screen "Controllable exterior screen"
extends IDEAS.Buildings.Components.Shading.Interfaces.PartialShadingDevice(
TSha = TShaScreen,
TDryBul_internal = Ctrl*TSha + (1-Ctrl)*Te_internal,
TDryBul_internal = Ctrl_internal*TSha + (1-Ctrl_internal)*Te_internal,
epsSw_shading = 1 - shaCorr,
final controlled = true,
TEnvExpr(y = TEnv_screen),
Expand All @@ -12,7 +12,7 @@ model Screen "Controllable exterior screen"
"Shortwave transmittance of the screen";

protected
Modelica.Units.SI.Temperature TEnv_screen = Ctrl*TSha + (1-Ctrl)*TEnv_internal
Modelica.Units.SI.Temperature TEnv_screen = Ctrl_internal*TSha + (1-Ctrl_internal)*TEnv_internal
"Assuming the environment temperature is a weighted average of the shading device temperature and the ambient temperature";
// This assumes that the window rejects 1-g_glazing of the incoming solar irradation is entirely converted into sensible heat
Modelica.Units.SI.Temperature TShaScreen = Te_internal + (HSha*(1-g_glazing) + (H - HSha) * epsSw_shading) /hSha
Expand All @@ -21,9 +21,9 @@ initial equation
assert(shaCorr + epsSw_shading <= 1, "In " + getInstanceName() +
": The sum of the screen transmittance 'shaCorr' and absorptance 'epsSw_shading' is larger than one. This is non-physical.");
equation
HShaDirTil = HDirTil*(1 - Ctrl);
HShaSkyDifTil = HSkyDifTil*(1 - Ctrl) + HSkyDifTil*Ctrl*shaCorr + HDirTil*Ctrl*shaCorr;
HShaGroDifTil = HGroDifTil*(1 - Ctrl) + HGroDifTil*Ctrl*shaCorr;
HShaDirTil = HDirTil*(1 - Ctrl_internal);
HShaSkyDifTil = HSkyDifTil*(1 - Ctrl_internal) + HSkyDifTil*Ctrl_internal*shaCorr + HDirTil*Ctrl_internal*shaCorr;
HShaGroDifTil = HGroDifTil*(1 - Ctrl_internal) + HGroDifTil*Ctrl_internal*shaCorr;

connect(angInc, iAngInc) annotation (Line(points={{-60,-50},{-14,-50},{-14,
-50},{40,-50}}, color={0,0,127}));
Expand All @@ -38,6 +38,10 @@ A fraction <code>shaCorr</code> is converted into diffuse light that enters the
</html>", revisions="<html>
<ul>
<li>
July 26, 2024 by Jelger Jansen:<br/>
Replace <code>Ctrl</code> by <code>Ctrl_internal</code> to avoid using a conditional component in a connect statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1367\">#1367</a>.
<li>
June 12, 2024 by Lucas Verleyen:<br/>
Remove limiter block. See <a href=\"https://github.com/open-ideas/IDEAS/issues/1290\">#1290</a>.
</li>
Expand Down
Loading