Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: mqttbroker Converge on one Dockerfile #566

Closed
johnwalicki opened this issue Oct 31, 2022 · 2 comments
Closed

Feature Request: mqttbroker Converge on one Dockerfile #566

johnwalicki opened this issue Oct 31, 2022 · 2 comments
Assignees

Comments

@johnwalicki
Copy link
Member

Is your feature request related to a problem? Please describe.

Using the technique described in #560 and implemented in #561
The same can be done for mqttbroker

Many of the examples/ repos have Dockerfile.amd64 / Dockerfile.arm / Dockerfile.arm64 / Dockerfile.ppc64le
I did a meld on some of these Dockerfiles and they are slightly different. (which is not good)
These multiple Dockerfiles and differences are unnecessary. We could delete them all. Create one common Dockerfile

Then in the Makefile, tell the docker build --platform linux/$(ARCH)
Docker/Podman will figure out which arch image to pull and build.

Describe the solution you'd like.

Remove all the Dockerfile.* files. Create a common Dockerfile

@saurav1004
Copy link
Contributor

@johnwalicki I think I can work on this issue. I can create a single dockerfile for the mqttbroker service (replacing the old ones) the way it is done for helloworld here. Could I be assigned this issue if I got it right ?

@t-fine
Copy link
Collaborator

t-fine commented Mar 4, 2023

As there were no changes to the services themselves, the version does not need to be incremented, and it does not need to be built and pushed. Closing.

@t-fine t-fine closed this as completed Mar 4, 2023
@github-project-automation github-project-automation bot moved this from Build and Push to Done in Documentation issues Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants