-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: helloSecretWorld - Converge on one Dockerfile #565
Comments
@johnwalicki similar to Issue #566, I can create a single dockerfile for the If you can assign me both issues, I can write both the dockerfiles and create a common PR ? |
@saurav1004 Since this examples repo is one giant repo, you can create a single PR which modifies files in multiple example subdirectories. Thanks for working on this issue. |
@johnwalicki I have made all necessary modifications for both the services |
Looks good. Nice work. Thanks! The PR is ready to merge once you remove the Draft status. |
Thanks !! I have removed the draft status. I think you can merge now. |
This change has been released: |
Is your feature request related to a problem? Please describe.
Using the technique described in #560 and implemented in #561
The same can be done for helloSecretWorld
Many of the examples/ repos have
Dockerfile.amd64
/Dockerfile.arm
/Dockerfile.arm64
/Dockerfile.ppc64le
I did a meld on some of these Dockerfiles and they are slightly different. (which is not good)
These multiple Dockerfiles and differences are unnecessary. We could delete them all. Create one common Dockerfile
Then in the
Makefile
, tell the docker build --platform linux/$(ARCH)Docker/Podman will figure out which arch image to pull and build.
Describe the solution you'd like.
Remove all the Dockerfile.* files. Create a common
Dockerfile
The text was updated successfully, but these errors were encountered: