PR review changes

Signed-off-by: Veinar <[email protected]>
open-gitops · Nov 8, 2023 · c8c28cc · c8c28cc
1 parent dbf2bd6
commit c8c28cc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -0,0 +1 @@
+node_modules/
diff --git a/Containerfile b/Containerfile
@@ -1,10 +1,10 @@
 # Use the NODE_VERSION argument to specify the Node.js version
-ARG NODE_VERSION
+ARG NODE_VERSION=20
 
 # Use the specified Node.js version as the base image
 FROM node:${NODE_VERSION}-alpine
 
-# Set Node args
+# Set Node args (do not set in node version 16 and below)
 ENV NODE_OPTIONS=--openssl-legacy-provider
 
 RUN apk add --update autoconf automake build-base libtool nasm pkgconf && \

diff --git a/README.md b/README.md
@@ -19,9 +19,12 @@ yarn start
 
 **Docker setup**
 ```shell
+# Build container image from local filesystem with default Node version
+docker build --no-cache -t website:<tag> -f Containerfile .
+
 # Build container image from local filesystem with Node version as build arg
 docker build --build-arg NODE_VERSION=19 --no-cache -t website:<tag> -f Containerfile .
 
 # Run container image with mapping port 80 on your computer
-docker run -dit -p 80:8000 website:<tag>
+docker run -dit -p 8000:8000 website:<tag>
 ```