Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CHANGELOG and necessary files for 3.1.0-alpha.0 release #794

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen requested a review from vaszig February 13, 2025 11:56
Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Changes will increase total bundle size by 28 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB 14 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 14 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 14 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/i18n/compiled/nl.json → Total Size: 25.76kB
view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/nl-*.js 14 bytes 23.38kB 0.06%

Files in assets/nl-*.js:

  • ./src/i18n/compiled/nl.json → Total Size: 25.76kB

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (c1f7d7e) to head (908e7e5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   84.23%   83.86%   -0.38%     
==========================================
  Files         245      245              
  Lines        4808     4808              
  Branches     1279     1272       -7     
==========================================
- Hits         4050     4032      -18     
- Misses        729      747      +18     
  Partials       29       29              
Flag Coverage Δ
storybook 77.44% <ø> (-0.50%) ⬇️
vitest 62.70% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments/recommendations but as I have understood from my personal experience, Changelog is difficult..

Maybe we should also add a description about the following to the changelog, what do you think?

  • Errors in ErrorBoundary are captured with Sentry.
  • Enabled Codecov JS bundle analysis.

And I see some missing translations :)

@robinmolen robinmolen force-pushed the release/3.1.0-alpha.0 branch from 2a3c4f2 to 77c8fb7 Compare February 17, 2025 14:33
@robinmolen
Copy link
Contributor Author

I have added some comments/recommendations but as I have understood from my personal experience, Changelog is difficult..

Yeah I totally agree 😄

Maybe we should also add a description about the following to the changelog, what do you think?

  • Errors in ErrorBoundary are captured with Sentry.
  • Enabled Codecov JS bundle analysis.

Yeah sounds good! I've included these to the "Project maintenance" changes.

And I see some missing translations :)

Ah nice catch! I've added them 👍

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only have to fix the failing tests and we are good to go.

Copy link

@viktorvanwijk viktorvanwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things :). Mostly personal preference, as there isn't really anything objectively wrong I would say.

@@ -2442,7 +2442,7 @@
"zpHAro": [
{
"type": 0,
"value": "Klik om een lijk te tekenen"
"value": "Klik om een lijn te tekenen"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this typo 💀

@robinmolen robinmolen force-pushed the release/3.1.0-alpha.0 branch from 8015967 to 908e7e5 Compare February 18, 2025 10:17
@robinmolen robinmolen merged commit 5e94e35 into main Feb 18, 2025
16 of 17 checks passed
@robinmolen robinmolen deleted the release/3.1.0-alpha.0 branch February 18, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 3.1.0-alpha.0
3 participants