-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CHANGELOG and necessary files for 3.1.0-alpha.0 release #794
Conversation
Bundle ReportChanges will increase total bundle size by 28 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 84.23% 83.86% -0.38%
==========================================
Files 245 245
Lines 4808 4808
Branches 1279 1272 -7
==========================================
- Hits 4050 4032 -18
- Misses 729 747 +18
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments/recommendations but as I have understood from my personal experience, Changelog is difficult..
Maybe we should also add a description about the following to the changelog, what do you think?
- Errors in ErrorBoundary are captured with Sentry.
- Enabled Codecov JS bundle analysis.
And I see some missing translations :)
2a3c4f2
to
77c8fb7
Compare
Yeah I totally agree 😄
Yeah sounds good! I've included these to the "Project maintenance" changes.
Ah nice catch! I've added them 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we only have to fix the failing tests and we are good to go.
77c8fb7
to
8015967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things :). Mostly personal preference, as there isn't really anything objectively wrong I would say.
@@ -2442,7 +2442,7 @@ | |||
"zpHAro": [ | |||
{ | |||
"type": 0, | |||
"value": "Klik om een lijk te tekenen" | |||
"value": "Klik om een lijn te tekenen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this typo 💀
8015967
to
908e7e5
Compare
Partly closes open-formulieren/open-forms#5102