-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display backend validation errors when submitting the form #792
Display backend validation errors when submitting the form #792
Conversation
Bundle ReportChanges will increase total bundle size by 6.18kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
|
I've opted to collect all the errors at the top and group them by step, rather than trying to weave this in the summary table. User research from Utrecht showed that this was the best way to show validation errors. Ideally, there would be some aria-describedby options, but that requires a lot more work to link everything together.
1355641
to
8a9df63
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 83.67% 83.88% +0.20%
==========================================
Files 244 245 +1
Lines 4777 4808 +31
Branches 1268 1272 +4
==========================================
+ Hits 3997 4033 +36
Misses 747 747
+ Partials 33 28 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Was broken in the refactors for the React Router upgrade, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add/mention!
Closes open-formulieren/open-forms#4510 - requires the backend PR to be merged as that changes the API endpoint used here.
I've opted to collect all the errors at the top and group them by step, rather than trying to weave this in the summary table. User research from Utrecht showed that this was the best way to show validation errors.
Ideally, there would be some aria-describedby options, but that requires a lot more work to link everything together.