-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Implement Requirement 1.1.3 #80
Merged
maxveldink
merged 15 commits into
open-feature:main
from
maxveldink:mveldink/0.7.0/flag-evaluation-api-1.1.3
Mar 9, 2024
Merged
feat!: Implement Requirement 1.1.3 #80
maxveldink
merged 15 commits into
open-feature:main
from
maxveldink:mveldink/0.7.0/flag-evaluation-api-1.1.3
Mar 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 12 12
Lines 164 166 +2
=======================================
+ Hits 163 165 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
move to Configuration instead of being directly on API. Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
…ider Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
josecolella
reviewed
Feb 28, 2024
beeme1mr
previously approved these changes
Mar 5, 2024
Signed-off-by: Max VelDink <[email protected]>
Signed-off-by: Max VelDink <[email protected]>
@open-feature/sdk-ruby-maintainers Would love to get this merged in soon as well if anyone has some time for a review! |
beeme1mr
approved these changes
Mar 7, 2024
beeme1mr
changed the title
feat: Implement Requirement 1.1.3
feat!: Implement Requirement 1.1.3
Mar 7, 2024
I updated the PR title to mark it as a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Only the last four commits will be merged in with this PR. The others are waiting on #77 and #78.
API.provider=(provider)
toAPI.set_provider(provider, domain: nil)
to better adhere to the specification. I decided to move away from theattr_writer
naming convention as thedomain
parameter would be surprising. I would love others' thoughts on this.nil
as the key. The other option I tried here was to store@default_provider
in addition to the hash, but this approach was simpler to the slight detriment of readability.API.provider
to receivedomain
as a keyword argument. If no domain is provided, it will return the default provider. This is backward compatible.Follow-up Tasks
In subsequent PRs, I'll continue on the flag evaluation specifications.
How to test
Open a console and play around with the
set_provider
method on the API. If no name is provided, the default provider will be replaced. If a name is provided, the provider will be registered using that name. If the same name is provided, the provider will be overridden.