-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Implement Requirement 1.1.2 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maxveldink
merged 13 commits into
open-feature:main
from
maxveldink:mveldink/0.7.0/flag-evaluation-api-1.1.2
Feb 22, 2024
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c109f7a
test: Add separate spec file for specification
maxveldink a1226d0
feat: Add API#set_provider
maxveldink 42461f5
feat: Allow API.set_provider to invoke init method
maxveldink 88a14ae
feat: Invoke shutdown during set_provider
maxveldink 21b5037
refactor: Rename set_provider to provider= and
maxveldink 45141a9
test: Add shutdown method to TestProvider
maxveldink b236c38
docs: adds comment/explicit nil to provider=
maxveldink 28c8957
docs: spruce up provider docs
maxveldink 07a564f
Merge branch 'main' into mveldink/0.7.0/flag-evaluation-api-1.1.2
maxveldink e17405a
Apply suggestions from code review
maxveldink 302e635
refactor: simplify shutdown check
maxveldink 7629f7f
Merge branch 'main' into mveldink/0.7.0/flag-evaluation-api-1.1.2
maxveldink f65650d
fix: Delegate provider= to configuration
maxveldink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# frozen_string_literal: true | ||
|
||
require "spec_helper" | ||
|
||
RSpec.describe OpenFeature::SDK::Configuration do | ||
subject(:configuration) { described_class.new } | ||
|
||
describe "#provider=" do | ||
context "when provider has an init method" do | ||
let(:provider) { TestProvider.new } | ||
|
||
it "inits and sets the provider" do | ||
expect(provider).to receive(:init) | ||
|
||
configuration.provider = provider | ||
|
||
expect(configuration.provider).to be(provider) | ||
end | ||
end | ||
|
||
context "when provider does not have an init method" do | ||
it "sets the provider" do | ||
provider = OpenFeature::SDK::Provider::NoOpProvider.new | ||
|
||
configuration.provider = provider | ||
|
||
expect(configuration.provider).to be(provider) | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# frozen_string_literal: true | ||
|
||
class TestProvider | ||
def init | ||
end | ||
|
||
def shutdown | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.