Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hook hints #135

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

mschoenlaub
Copy link
Contributor

@mschoenlaub mschoenlaub commented May 1, 2024

This PR

Related Issues

A first step towards fixing #52 .

Notes

Follow-up Tasks

Use this data structure in follow-up PRs to implement hooks.

How to test

N/A

@mschoenlaub mschoenlaub requested a review from a team as a code owner May 1, 2024 18:50
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (50bdf48) to head (4462260).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   99.48%   99.53%   +0.04%     
==========================================
  Files          15       16       +1     
  Lines         196      214      +18     
==========================================
+ Hits          195      213      +18     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschoenlaub mschoenlaub force-pushed the hook-hints branch 3 times, most recently from 5660c94 to 20cf539 Compare May 1, 2024 18:56
beeme1mr
beeme1mr previously approved these changes May 1, 2024
@mschoenlaub mschoenlaub marked this pull request as draft May 1, 2024 19:05
@mschoenlaub mschoenlaub marked this pull request as ready for review May 2, 2024 06:45
Signed-off-by: Manuel Schönlaub <[email protected]>
Copy link
Member

@maxveldink maxveldink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑 Cool, yea no issues as written for me. I think we'll want to standardize around this ALLOWED_* approach in other parts of the SDK, so I'm glad we're experimenting with it here.

@maxveldink maxveldink merged commit 51155a7 into open-feature:main May 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants