Skip to content

refactor: replace exception raising with error flag resolution #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Mar 30, 2025

This PR

  • this has actually no consequences for SDK users, because we already properly sending the errors inside the flag evaluation and only internally raised an exception. if someone used the privately marked methods, then it is a breaking change for them, but that's nothing we guarantee stability for.

Related Issues

Fixes #466

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (5a2825b) to head (ec2d44a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   97.85%   97.44%   -0.42%     
==========================================
  Files          37       37              
  Lines        1723     1759      +36     
==========================================
+ Hits         1686     1714      +28     
- Misses         37       45       +8     
Flag Coverage Δ
unittests 97.44% <100.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gruebel gruebel requested review from beeme1mr and aepfli March 31, 2025 06:53
@gruebel gruebel requested review from a team as code owners April 7, 2025 14:30
@gruebel gruebel merged commit e61b69b into main Apr 8, 2025
13 of 14 checks passed
@gruebel gruebel deleted the use-error-codes branch April 8, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Handle errorneous flag evaluation without exceptions
3 participants