-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace deprecated gcr.io/kubebuilder/kube-rbac-proxy #733
Conversation
Signed-off-by: Lukas Reining <[email protected]>
97d1b78
to
ed9e319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a massive PR but the changes look good. Thanks for working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @lukas-reining . I can't see anything clearly wrong, so I'm approving thought I left a question.
Also, did you also make sure that you tested a local helm install (we don't have CI for this as mentioned here)?
If you didn't, you can use the make commands to build a local helm distribution and test that all the helm templating still works. That's about the only big thing not covered by the CI. I can also do this tomorrow if you don't have time.
@lukas-reining I packaged this locally and installed it with helm as in https://openfeature.dev/docs/tutorials/open-feature-operator/quick-start, and it worked great! I didn't test it with a new container built from this branch, but that should be covered by the CI. As far as I'm concerned you can merge this whenever. Thanks again. |
Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
Thanks, as written, I fixed the certificate dns name for helm. |
Tested again, looks good. |
Updates to kubebuilder scaffold v4.
This is needed as we have to migrate away from
kube-rbac-proxy
as seen in #724.This PR also removes
kube-rbac-proxy
and switches tometricsServerOptions.FilterProvider = filters.WithAuthenticationAndAuthorization
to implement RBAC.Fixes #724