Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated gcr.io/kubebuilder/kube-rbac-proxy #733

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

lukas-reining
Copy link
Member

@lukas-reining lukas-reining commented Jan 28, 2025

Updates to kubebuilder scaffold v4.
This is needed as we have to migrate away fromkube-rbac-proxy as seen in #724.

This PR also removes kube-rbac-proxy and switches to metricsServerOptions.FilterProvider = filters.WithAuthenticationAndAuthorization to implement RBAC.

Fixes #724

Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining lukas-reining self-assigned this Jan 28, 2025
@lukas-reining lukas-reining marked this pull request as ready for review January 28, 2025 16:22
@lukas-reining lukas-reining requested a review from a team as a code owner January 28, 2025 16:22
@lukas-reining lukas-reining requested review from beeme1mr, toddbaert, odubajDT and a team January 28, 2025 16:22
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a massive PR but the changes look good. Thanks for working on this.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @lukas-reining . I can't see anything clearly wrong, so I'm approving thought I left a question.

Also, did you also make sure that you tested a local helm install (we don't have CI for this as mentioned here)?

If you didn't, you can use the make commands to build a local helm distribution and test that all the helm templating still works. That's about the only big thing not covered by the CI. I can also do this tomorrow if you don't have time.

@toddbaert
Copy link
Member

toddbaert commented Jan 30, 2025

@lukas-reining I packaged this locally and installed it with helm as in https://openfeature.dev/docs/tutorials/open-feature-operator/quick-start, and it worked great! I didn't test it with a new container built from this branch, but that should be covered by the CI.

As far as I'm concerned you can merge this whenever. Thanks again.

@lukas-reining
Copy link
Member Author

@lukas-reining I packaged this locally and installed it with helm as in https://openfeature.dev/docs/tutorials/open-feature-operator/quick-start, and it worked great! I didn't test it with a new container built from this branch, but that should be covered by the CI.

Thanks, as written, I fixed the certificate dns name for helm.

@toddbaert
Copy link
Member

@lukas-reining I packaged this locally and installed it with helm as in https://openfeature.dev/docs/tutorials/open-feature-operator/quick-start, and it worked great! I didn't test it with a new container built from this branch, but that should be covered by the CI.

Thanks, as written, I fixed the certificate dns name for helm.

Tested again, looks good.

@toddbaert toddbaert merged commit 5358d1e into main Jan 30, 2025
16 checks passed
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
@lukas-reining lukas-reining deleted the chore/scaffold-v4 branch January 30, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy
3 participants