Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release OpenFeature.Contrib.Hooks.Otel 0.1.4 #142

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 22, 2024

🤖 I have created a release beep boop

0.1.4 (2024-01-25)

🧹 Chore


This PR was generated with Release Please. See documentation.

@github-actions github-actions bot requested a review from a team as a code owner January 22, 2024 15:59
@github-actions github-actions bot force-pushed the release-please--branches--main--components--OpenFeature.Contrib.Hooks.Otel branch from bf71af6 to 4bcc649 Compare January 22, 2024 15:59
@github-actions github-actions bot force-pushed the release-please--branches--main--components--OpenFeature.Contrib.Hooks.Otel branch 2 times, most recently from 30203a4 to 1cb4dcd Compare January 24, 2024 13:52
@austindrenski austindrenski force-pushed the release-please--branches--main--components--OpenFeature.Contrib.Hooks.Otel branch from 1cb4dcd to f092f8f Compare January 24, 2024 14:08
Copy link
Member

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but want to call out that there are several relevant commits not being picked up by the release-please bot, most notably the reduction in dependencies used by this package, as well as the shared SDK version bump...

Not sure if that's something we can configure/fix, but might be worth some thought before we get to the next major/breaking release.

@toddbaert
Copy link
Member

Approving but want to call out that there are several relevant commits not being picked up by the release-please bot, most notably the reduction in dependencies used by this package, as well as the shared SDK version bump...

Not sure if that's something we can configure/fix, but might be worth some thought before we get to the next major/breaking release.

Release please only picks up on changes within the component subfolder (like I mentioned here). I'm not sure exactly what changes you're referring to, but I'm guessing they we in the parent dir(s)?

@toddbaert
Copy link
Member

toddbaert commented Jan 24, 2024

Oh, is it #132?

Ya, actually, that's very strange. I wonder if it's the "refactor" semantic commit type? I would think that should work fine, but I maybe it's not supported 🤔

Nope, that's captured in a recent release from Jan 11: https://github.com/open-feature/dotnet-sdk-contrib/releases/tag/OpenFeature.Contrib.Hooks.Otel-v0.1.3 (release please PR here)

@austindrenski does this release contain what you were worried about? Is there anything else missing?

@austindrenski
Copy link
Member

Oh, is it #132?

Ya, actually, that's very strange. I wonder if it's the "refactor" semantic commit type? I would think that should work fine, but I maybe it's not supported 🤔

Nope, that's captured in a recent release from Jan 11: https://github.com/open-feature/dotnet-sdk-contrib/releases/tag/OpenFeature.Contrib.Hooks.Otel-v0.1.3 (release please PR here)

@austindrenski does this release contain what you were worried about? Is there anything else missing?

Oh woof, you're right, sorry, for some reason I had it in my head that #132 landed late last week, so wasn't expecting it to have been released already 🤦

Release please only picks up on changes within the component subfolder (like I mentioned here). I'm not sure exactly what changes you're referring to, but I'm guessing they we in the parent dir(s)?

The other one I was referencing was #144 which, as you surmised, did not touch anything in this directory, but it did touch the shared SDK which makes me think that perhaps we need to configure release-please to understand the *.csproj -> ../Directory.Build.props -> ../build/Common.prod.props -> ../build/Common.props linkages?

Idk, not a big deal for now, just thinking that it would be nice to have repo-wide effects captured in these changelogs as we attract more consumers and contributors over time.

@github-actions github-actions bot force-pushed the release-please--branches--main--components--OpenFeature.Contrib.Hooks.Otel branch from f092f8f to c8369a5 Compare January 25, 2024 16:26
@austindrenski
Copy link
Member

@open-feature/sdk-dotnet-maintainers Can I get a second approval on this so we can get a stable version of this package released with support for #144?

@toddbaert toddbaert merged commit e112f6c into main Jan 26, 2024
6 checks passed
Copy link
Contributor Author

@austindrenski austindrenski deleted the release-please--branches--main--components--OpenFeature.Contrib.Hooks.Otel branch January 26, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants