-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release OpenFeature.Contrib.Hooks.Otel 0.1.4 #142
chore(main): release OpenFeature.Contrib.Hooks.Otel 0.1.4 #142
Conversation
bf71af6
to
4bcc649
Compare
30203a4
to
1cb4dcd
Compare
1cb4dcd
to
f092f8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but want to call out that there are several relevant commits not being picked up by the release-please bot, most notably the reduction in dependencies used by this package, as well as the shared SDK version bump...
Not sure if that's something we can configure/fix, but might be worth some thought before we get to the next major/breaking release.
Release please only picks up on changes within the component subfolder (like I mentioned here). I'm not sure exactly what changes you're referring to, but I'm guessing they we in the parent dir(s)? |
Oh, is it #132?
Nope, that's captured in a recent release from Jan 11: https://github.com/open-feature/dotnet-sdk-contrib/releases/tag/OpenFeature.Contrib.Hooks.Otel-v0.1.3 (release please PR here) @austindrenski does this release contain what you were worried about? Is there anything else missing? |
Oh woof, you're right, sorry, for some reason I had it in my head that #132 landed late last week, so wasn't expecting it to have been released already 🤦
The other one I was referencing was #144 which, as you surmised, did not touch anything in this directory, but it did touch the shared SDK which makes me think that perhaps we need to configure release-please to understand the Idk, not a big deal for now, just thinking that it would be nice to have repo-wide effects captured in these changelogs as we attract more consumers and contributors over time. |
f092f8f
to
c8369a5
Compare
@open-feature/sdk-dotnet-maintainers Can I get a second approval on this so we can get a stable version of this package released with support for #144? |
…OpenFeature.Contrib.Hooks.Otel
🤖 I have created a release beep boop
0.1.4 (2024-01-25)
🧹 Chore
This PR was generated with Release Please. See documentation.