Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename UclaMiniscopeV4CameraFrame #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename UclaMiniscopeV4CameraFrame #380

wants to merge 1 commit into from

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Dec 6, 2024

Resolve #379

  • UclaMiniscopeV4CameraFrame -> UclaMiniscopeV4CameraDataFrame
  • fix references xml comments after changing name

@cjsha
Rename UclaMiniscopeV4CameraFrame
2caba31 
- UclaMiniscopeV4CameraFrame ->
  UclaMiniscopeV4CameraDataFrame
- fix references xml comments after changing name
@cjsha cjsha requested a review from jonnew December 6, 2024 15:37
@jonnew
Copy link
Member

jonnew commented Jan 2, 2025

If we want to do this, we will need to do a minor version update and probably some trickery for maintaining back compatibility:

bonsai-onix1/OpenEphys.Onix1/PolledBno055Data.cs

Line 212 in 3ee5b2c

public class NeuropixelsV1eBno055Data : PolledBno055Data { }

@jonnew jonnew added this to the 0.5.0 milestone Jan 2, 2025
@cjsha
Copy link
Member Author

cjsha commented Jan 2, 2025

I guess I'm still not sure we want to do this - there might be a reason it's like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew Awaiting requested review from jonnew

At least 1 approving review is required to merge this pull request.

Assignees

@jonnew jonnew

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Change class name UclaMiniscopeV4CameraFrame -> UclaMiniscopeV4CameraDataFrame
2 participants
@cjsha @jonnew