Modify NeuropixelsV2e dialogs to scale correctly #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah upsides far outweigh the downsides. I tested on my laptop oat various zooms without issue. Nice. |
jonnew
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At scale values different from 100% on Windows 11 machines, the
NeuropixelsV2edialogs would not scale correctly, leading to hidden controls and making the GUI effectively useless.In this PR, all
NeuropixelsV2edialogs were updated to useFlowLayoutPanelandTableLayoutPanelinstead ofSplitterPanel, as the two former panels handle resizing at different scale values more robustly than the latter.One consequence of switching to these panels is that they are no longer movable from the user perspective; that is, all panel sizes are locked to their relative size. To view the full filepath for a configuration file, sometimes when maximizing the window it will show the entire path; if that is not enough, the filepath is inside of a textbox that can be selected and stepped through using the arrow keys to view the path.
Fixes #241