Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Tutorials for np1e & np2e headstages #50

Merged
merged 7 commits into from
Sep 19, 2024
Merged

WIP Tutorials for np1e & np2e headstages #50

merged 7 commits into from
Sep 19, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Aug 23, 2024

resolves #48

Lacks content for configuring the neuropixels probes.

Lacks Python script for loading data.

cjsha added 2 commits August 23, 2024 17:34
- Preliminary tutorials for np1e & np2e
- tutorials organized into partial templates rather than an extended markdown
  file so that bits and pieces can be reused for
- enums templating fixed (issue #48)
@jonnew jonnew marked this pull request as draft August 28, 2024 16:56
@jonnew jonnew marked this pull request as ready for review August 28, 2024 16:57
@jonnew jonnew marked this pull request as draft August 28, 2024 16:57
@cjsha
Copy link
Member Author

cjsha commented Aug 28, 2024

I noticed there will be a bunch of repeated text between different tutorials. So part of this PR is proposing that we use templates where there is a bunch of repeated text in tutorials.

It's still lacking screenshots of "real world" behavior.

@cjsha cjsha marked this pull request as ready for review August 28, 2024 17:52
@cjsha cjsha marked this pull request as draft August 28, 2024 18:55
cjsha added 2 commits August 28, 2024 15:22
- Also, add references to the GUI in the template
- This is WIP, but I want to get something out so that users have
  tutorial content for np2 headstages
- Had to set `git config core.ignorecase false`
@cjsha cjsha requested a review from bparks13 August 28, 2024 20:05
@cjsha
Copy link
Member Author

cjsha commented Aug 28, 2024

It's far from complete (i.e. check out the above comments), but I want to get merge to main if it looks ok because I'm getting input from @ChucklesOnGitHub that we should get the workflows up there asap.

@cjsha cjsha marked this pull request as ready for review August 28, 2024 20:07
@cjsha cjsha requested review from ChucklesOnGitHub and removed request for bparks13 August 30, 2024 14:25
- Update src pointer to latest commit on main
- Add titles
- delete unnecessary workflows
@cjsha
Copy link
Member Author

cjsha commented Sep 5, 2024

This intent for this PR is to publish where I left off writing NP tutorial content before starting to restructure the tutorial content. I don't want to do what I indicated I wanted to do regarding using templates in the way that they are implemented in this PR, but I want to merge this and deploy some NP content for people to get started, which is urgent.

It addresses #35 and #36 but does not close them.

@cjsha cjsha requested a review from bparks13 September 5, 2024 17:46
@cjsha cjsha changed the title Tutorials for np1e & np2e headstages WIP Tutorials for np1e & np2e headstages Sep 5, 2024
@cjsha cjsha marked this pull request as draft September 6, 2024 12:58
@cjsha cjsha marked this pull request as ready for review September 19, 2024 14:05
@cjsha cjsha merged commit 4056f09 into main Sep 19, 2024
3 checks passed
@cjsha cjsha deleted the np2e-np1e-tutorial branch October 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum comments are not being extracted correctly on their own page
2 participants