Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout tutorial #39

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Breakout tutorial #39

merged 7 commits into from
Aug 23, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Aug 20, 2024

This a first draft of the breakout board tutorial. It's still missing a data loading script and explanation of said script but its a base to start commenting on and improving.

jonnew added 2 commits August 14, 2024 17:16
- Need to finish documenting workflow
- Need to add data loading scripts and explaination
- It still needs a data loading section
@jonnew jonnew requested review from bparks13 and cjsha August 20, 2024 22:41
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like it's tutorial time for me.

I think we should try rendering the cropped workflow pngs in a way that's similar to how the BreakoutBoard.svg is rendered. But that's low-priority compared to getting the rest of the tutorial content out.

It feels a bit like a wall of text, but I think that's just what it has to be?

tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
@jonnew
Copy link
Member Author

jonnew commented Aug 21, 2024

Thanks for the feedback:

  • SVG - yeah for sure. Also a non numerical file naming scheme because numerical ordering makes it weird to put pictures in between existing ones
  • Wall of text - yes. I'm hoping that the section is further expanded with mor explanatory images. I would like you to look into that when you have time.

So, I will go through these edits and implement. Also I want to make a data loading script, which I will put at the bottom. After that, it would be good if you could flesh out with even more images.

tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
tutorials/breakoutboard-tut.md Outdated Show resolved Hide resolved
@cjsha
Copy link
Member

cjsha commented Aug 21, 2024

Quick aside. If you select a bunch of operators and click Ctrl+Shift+E (the export hotkeys), you can export a snippet of a workflow. I try to demonstrate in the below screenshot where I'm drag-selecting a section of operators you want to export and then export (you don't have to be drag-selecting while pressing Ctrl+Shift+E - as long as the operators are selected).
image

Maybe this becomes annoying to maintain if you change the properties in the overarching workflow.svg though

@jonnew
Copy link
Member Author

jonnew commented Aug 21, 2024

uhhh... oh. Thats helpful.

@cjsha
Copy link
Member

cjsha commented Aug 21, 2024

One more thing, what convention should we follow for capitalizing headers?

- Replace pngs of partial workflows with svgs
- Fixe many typos, etc
@jonnew
Copy link
Member Author

jonnew commented Aug 21, 2024

Good question. I think we should follow the Open Ephys GUI docs convention:

  • Site Section Titles
  • Page Titles
  • Page section titles

- This tutorial is still missing a data loadin script
@cjsha cjsha self-requested a review August 22, 2024 15:59
@cjsha
Copy link
Member

cjsha commented Aug 22, 2024

I'm starting to wonder if we should break this tutorial down into smaller sections. I think the "wall of text" feeling isn't due to a lack of images, I think it's more due to the sheer amount of content/text. For instance, each of these could be its own page:
image

If we do want to break up the text a little bit, the only images I can think of adding are ones that indicate to the user how the breakout board is supposed to behave if it's functioning correctly. Here are some examples:

  • Screenshots showing visualizers (in a section like "Memory monitor"?)
  • GIFs that demonstrate the workflow/Onix system responding to or enacting visual changes in "the real world". For instance, if a workflow does something in response to a user setting a digital input HIGH, the user's action + the workflow's response can be shown in a GIF. Or similarly, if Bonsai is controlling the state of an LED, that can be shown in a GIF.

@jonnew
Copy link
Member Author

jonnew commented Aug 22, 2024

Although i get what you are saying, I also kinda really don't like it when pages are all cut up into tiny 1 paragraph pieces either. I do think showing visualizer outputs would be a good idea. I think we should throw that into an issue (e.g. Add visualizer in action examples to tutorials) and try to merge this in the meantime.

@cjsha cjsha merged commit 5a379aa into main Aug 23, 2024
3 checks passed
@cjsha cjsha deleted the breakout-tutorial branch August 23, 2024 21:13
@jonnew jonnew mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants