Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motivate heartbeat functionality in breakout #134

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Motivate heartbeat functionality in breakout #134

merged 3 commits into from
Oct 30, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Oct 29, 2024

resolve #94

@cjsha cjsha requested a review from jonnew October 29, 2024 21:03
jonnew
jonnew approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some text changes, but overall looks good. Have a look at what i did and feel free to change things back if you think its worse.

@jonnew jonnew merged commit 9048b71 into main Oct 30, 2024
3 checks passed
@cjsha cjsha deleted the issue-94 branch November 14, 2024 14:31
@cjsha cjsha restored the issue-94 branch November 14, 2024 14:31
@cjsha cjsha deleted the issue-94 branch November 25, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew jonnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Heartbeat from Breakout Board Example Workflow
2 participants
@cjsha @jonnew