Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule #133

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Update submodule #133

merged 2 commits into from
Nov 4, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Oct 29, 2024

  • Add workflows for new operators

Resolve #129

- Add workflows for new operators
@bparks13
Copy link
Member

@cjsha I would recommend instead of pointing to that commit, we should point to open-ephys/bonsai-onix1@18dd66b. This is the commit that was tagged as v0.4.0, and as such should be a direct reflection of the state of the library that an end user can download.

@jonnew what do you think?

@cjsha
Copy link
Member Author

cjsha commented Oct 31, 2024

there has only been one PR since v0.4.0 (at the time of updating the submodule pointer) and it doesn't seem like it would end up changing the docs, but yeah what you suggest is best practice. Whenever we have a new release, it would be cool to have a notification or something in the docs repo that it needs to point to a later version. I made a wishlist issue #141 for that

@bparks13 bparks13 merged commit 5fc1a43 into main Nov 4, 2024
3 checks passed
@bparks13 bparks13 deleted the update-submodule branch November 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rhs2116 missing from Reference pages
2 participants