-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyphenate URLs & update the "install bonsai" page for Onix1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specifically: - OpenEphys.Onix -> OpenEphys.Onix1 - onix: -> onix1: - Also, change reference from neurogears onix-docs repo to open-ephys onix1-bonsai-docs repo
- In addition to previous commit's refactors: ``xmlns:onix=`` --> ``xmlns:onix1``
- Not all files underwent the OpenEphys.Onix -> OpenEphysOnix1 refactor previously. This is fixed now
- change text in md files: onix -> onix1 - dataFrame only shows up once (on nP2eBno055Data operator for example) - remove comment under Misc headers - add table for dataFrames that are enums - fix links in abc -> o -> xyz diagrams - data frames and context task anchor to subheader - external types (bool, mat, etc.) link externally - use different summary and headers under ContextTask for aggregate nodes - Add input's dataFrame table when there is no output dataFrame (like StartAcquisition though this behavior might need to change)
…into template-update
- Underscores in file names replaced with hyphens - Update screenshots and rewrite some steps for installing Bonsai & OpenEphys.Onix1 package - New directory for putting editable screenshots to improve ease of maintaining edited screenshots used for docs
- The deletion of this file caused a merge conflict o.O
- use a <h2> tag instead of <a> tag
bparks13
requested changes
Aug 8, 2024
- Also add periods and make other little changes according to Brandon's comments in the PR
- workflows still needed to be renamed after hyphenating everything
- for the purpose of fixing broken references
bparks13
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few quick fixes and we should be good to push this live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.