Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenate URLs & update the "install bonsai" page for Onix1 #13

Merged
merged 14 commits into from
Aug 9, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Aug 8, 2024

No description provided.

cjsha added 7 commits August 5, 2024 12:41
- Specifically:
  - OpenEphys.Onix -> OpenEphys.Onix1
  - onix: -> onix1:
- Also, change reference from neurogears onix-docs repo to open-ephys
  onix1-bonsai-docs repo
- In addition to previous commit's refactors: ``xmlns:onix=`` --> ``xmlns:onix1``
- Not all files underwent the OpenEphys.Onix -> OpenEphysOnix1 refactor
  previously. This is fixed now
- change text in md files: onix -> onix1
- dataFrame only shows up once (on nP2eBno055Data operator for example)
- remove comment under Misc headers
- add table for dataFrames that are enums
- fix links in abc -> o -> xyz diagrams
  - data frames and context task anchor to subheader
  - external types (bool, mat, etc.) link externally
- use different summary and headers under ContextTask for aggregate
  nodes
- Add input's dataFrame table when there is no output dataFrame (like
  StartAcquisition though this behavior might need to change)
- Underscores in file names replaced with hyphens
- Update screenshots and rewrite some steps for installing Bonsai &
  OpenEphys.Onix1 package
- New directory for putting editable screenshots to improve ease of
  maintaining edited screenshots used for docs
@cjsha cjsha requested a review from bparks13 August 8, 2024 23:01
@cjsha cjsha changed the title Hyphenate URLs & update the "install bonsai" page Hyphenate URLs & update the "install bonsai" page for Onix1 Aug 8, 2024
cjsha added 2 commits August 8, 2024 19:17
- The deletion of this file caused a merge conflict o.O
- use a <h2> tag instead of <a> tag
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install_and_download.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install-configure-bonsai.md Outdated Show resolved Hide resolved
articles/getting-started/install_and_download.md Outdated Show resolved Hide resolved
cjsha added 4 commits August 8, 2024 21:56
- Also add periods and make other little changes according to Brandon's
  comments in the PR
- workflows still needed to be renamed after hyphenating everything
- for the purpose of fixing broken references
@cjsha cjsha requested a review from bparks13 August 9, 2024 11:43
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few quick fixes and we should be good to push this live

@cjsha cjsha merged commit 4001458 into main Aug 9, 2024
3 checks passed
@cjsha cjsha deleted the hyphenate-URLs_update-installbonsai-page branch August 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants