Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playbooks #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update playbooks #5

wants to merge 4 commits into from

Conversation

SorinAlexB
Copy link

@SorinAlexB SorinAlexB commented Mar 16, 2024

Lack of yaml files for modules and issues with docker group. The problems were solved by updating the playbooks with new yaml files and updating the master yaml file.

Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the commit messages:

  • Use present tense.
  • Add a description message for each commit.

@SorinAlexB SorinAlexB requested a review from razvand March 16, 2024 14:13
@SorinAlexB SorinAlexB changed the title Updated playbooks Update playbooks Mar 16, 2024
@SorinAlexB SorinAlexB force-pushed the vagrant_sorin branch 3 times, most recently from f88a867 to 754b4cb Compare March 18, 2024 14:55
Sorin Birchi added 4 commits March 18, 2024 18:20
Creating toml files for commons, zeratool_lib, vulnerability_analytics, opencrs_dataset, wiki, nic_c_test_suite and awesome-binary-analysis repos

Signed-off-by: Sorin Birchi <[email protected]>
Create toml file for signature_generation module

Signed-off-by: Sorin Birchi <[email protected]>
Using python 3.12 will result into an error because distutils is no longer supported. Downgrading to python 3.10 will solve this issue.

Signed-off-by: Sorin Birchi <[email protected]>
Create toml file for vulnerability_detection

Signed-off-by: Sorin Birchi <[email protected]>
Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure files don't have trailing white spaces. Make sure they are newline-ended. Make sure there are no conflict residues.

Make sure the commit messages wrap at 72 characters.

@@ -16,7 +16,10 @@
args:
chdir: /home/{{ username }}/attack_surface_approximation/

<<<<<<< HEAD:playbooks-opencrs/attack-surface-approx.yml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unsolved conflict. Take care of it.

# args:
# chdir: /home/{{ username }}/vulnerability_analytics/
# executable: /bin/bash
# become: yes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the file is newline-ended.

@@ -18,4 +18,5 @@
ansible.builtin.shell: docker build --tag ubuntu_32bit_compilator others/ubuntu_32bit_compilator
args:
chdir: /home/{{ username }}/dataset/

executable: /bin/bash
become: yes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the file is newline-ended.

args:
chdir: /home/{{ username }}/automatic_exploit_generation/
executable: /bin/bash
become: yes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the file is newline-ended.

@@ -14,6 +17,13 @@
chdir: /home/{{ username }}/vulnerability_detection/

- name: Build vulnerability_detection docker container
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unsolved conflict. Take care of it.

Comment on lines +10 to +12



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove excess white lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants