-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update playbooks #5
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the commit messages:
- Use present tense.
- Add a description message for each commit.
abbf5b3
to
e219a35
Compare
f88a867
to
754b4cb
Compare
Creating toml files for commons, zeratool_lib, vulnerability_analytics, opencrs_dataset, wiki, nic_c_test_suite and awesome-binary-analysis repos Signed-off-by: Sorin Birchi <[email protected]>
Create toml file for signature_generation module Signed-off-by: Sorin Birchi <[email protected]>
Using python 3.12 will result into an error because distutils is no longer supported. Downgrading to python 3.10 will solve this issue. Signed-off-by: Sorin Birchi <[email protected]>
Create toml file for vulnerability_detection Signed-off-by: Sorin Birchi <[email protected]>
754b4cb
to
9d0704f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure files don't have trailing white spaces. Make sure they are newline-ended. Make sure there are no conflict residues.
Make sure the commit messages wrap at 72 characters.
@@ -16,7 +16,10 @@ | |||
args: | |||
chdir: /home/{{ username }}/attack_surface_approximation/ | |||
|
|||
<<<<<<< HEAD:playbooks-opencrs/attack-surface-approx.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unsolved conflict. Take care of it.
# args: | ||
# chdir: /home/{{ username }}/vulnerability_analytics/ | ||
# executable: /bin/bash | ||
# become: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the file is newline-ended.
@@ -18,4 +18,5 @@ | |||
ansible.builtin.shell: docker build --tag ubuntu_32bit_compilator others/ubuntu_32bit_compilator | |||
args: | |||
chdir: /home/{{ username }}/dataset/ | |||
|
|||
executable: /bin/bash | |||
become: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the file is newline-ended.
args: | ||
chdir: /home/{{ username }}/automatic_exploit_generation/ | ||
executable: /bin/bash | ||
become: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the file is newline-ended.
@@ -14,6 +17,13 @@ | |||
chdir: /home/{{ username }}/vulnerability_detection/ | |||
|
|||
- name: Build vulnerability_detection docker container | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unsolved conflict. Take care of it.
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove excess white lines.
Lack of yaml files for modules and issues with docker group. The problems were solved by updating the playbooks with new yaml files and updating the master yaml file.