Skip to content

Commit

Permalink
fix: auto-build images in nightly
Browse files Browse the repository at this point in the history
MFE images were not automatically built in nightly: this occurred both
in local and dev mode.

Close overhangio#157
  • Loading branch information
regisb authored and arbrandes committed Nov 1, 2023
1 parent 455bd21 commit 4d19ec7
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tutormfe/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,12 @@ def _print_mfe_public_hosts(
def _build_3rd_party_dev_mfes_on_launch(
image_names: list[str], context_name: t.Literal["local", "dev"]
) -> list[str]:
if context_name == "dev":
for mfe_name, _mfe_attrs in iter_mfes():
if mfe_name not in CORE_MFE_APPS:
# We don't require to build core MFEs because images are available from
# the public registry.
image_names.append(f"{mfe_name}-dev")
for mfe_name, _mfe_attrs in iter_mfes():
if __version_suffix__ or (context_name == "dev" and mfe_name not in CORE_MFE_APPS):
# We build MFE images:
# - in nightly
# - in development for non-core apps
image_names.append(f"{mfe_name}-dev")
return image_names


Expand Down

0 comments on commit 4d19ec7

Please sign in to comment.