Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable scroll in grading modal #5

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: enable scroll in grading modal #5

merged 1 commit into from
Sep 17, 2024

Conversation

viadanna
Copy link
Member

Description

This pull request introduces scrollbars to the MFE to improve the user experience when dealing with large content areas.

Testing instructions

  1. Deploy this to an instance.
  2. Submit an ORA with many images and/or a large amount of text.
  3. Go to the Instructor Dashboard > Open Assessment and start grading.
  4. Ensure scrollbars show in the fullscreen modal window.

Deadline
ASAP

kaustavb12
kaustavb12 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@kaustavb12 kaustavb12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: Tested in sandbox
  • I read through the code

@viadanna viadanna merged commit cc8cc1f into asu-moe/redwood-css Sep 17, 2024
4 checks passed
@viadanna viadanna deleted the viadanna/scrolling-fix branch September 17, 2024 18:47
@viadanna viadanna mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaustavb12 kaustavb12 kaustavb12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viadanna @kaustavb12