feat: port code drift for open-craft/frontend-app-gradebook [BB-8367] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## opencraft-release/quince.1 #4 +/- ##
=============================================================
Coverage ? 94.98%
=============================================================
Files ? 140
Lines ? 1356
Branches ? 264
=============================================================
Hits ? 1288
Misses ? 60
Partials ? 8 ☔ View full report in Codecov by Sentry. |
I would argue that this is not "non-upstreamable", we can have the MFE pull additional allowed roles from the config API and keep the existing default roles. However, that is out of scope here so I think this is good to merge. |
xitij2000
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gradebook MFE has only one non-upstreamable commit that we have to carry. Diff.