feat: use search manager (TEMP) #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
…753-library-home-page-bare-bones
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
b948788
to
f902335
Compare
…/fal-3764-library-home-filter-by-content-type
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
cf0e3c1
to
1bf2708
Compare
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
a418e39
to
07b3a03
Compare
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
07b3a03
to
dfd3190
Compare
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
78bbf84
to
3400f71
Compare
rpenido
commented
Jul 4, 2024
| showContent: resultShowContent, | ||
| }; | ||
| }, [isFetching, isFetchingNextPage]); | ||
| const showLoading = isFetching || isFetchingNextPage; |
There was a problem hiding this comment.
Removing the loading state when we already have data to make the transition smooth.
| With loading | Without loading |
|---|---|
There was a problem hiding this comment.
I think it looks much nicer without the loading, nice addition!
yusuf-musleh
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
@rpenido 👍 Great work on this! I've tested it out and everything is looking good, just left a new few nits/comments.
- I tested this:
- Tested filtering by tags
- Tested searching for tags to filter by
- Tested filtering by block type
- Tested clearing all applied filters
- Tested clearing a single applied filter
- Tested searching still works as expected
- I read through the code
- I checked for accessibility issues
-
Includes documentation
src/search-manager/FilterByTags.tsx
Outdated
There was a problem hiding this comment.
The labels in the Tags filter dropdown are not aligned:
We can add the mb-0 class to this line in this file in order to fix the issue.
Comment on lines
112
to
114
| <Tab eventKey={TAB_LIST.home} title="Home" /> | ||
| <Tab eventKey={TAB_LIST.components} title="Components" /> | ||
| <Tab eventKey={TAB_LIST.collections} title="Collections" /> |
There was a problem hiding this comment.
nit: The titles should be translated (this should probably be changed in the base branch cc: @ChrisChV)
| showContent: resultShowContent, | ||
| }; | ||
| }, [isFetching, isFetchingNextPage]); | ||
| const showLoading = isFetching || isFetchingNextPage; |
There was a problem hiding this comment.
I think it looks much nicer without the loading, nice addition!
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
from
2672082
to
c453ef0
Compare
…nido/fal-3764-library-home-filter-by-content-type
ChrisChV
force-pushed
the
chris/FAL-3757-components-tab
branch
from
0a962a0
to
32838a3
Compare
|
Closed in favor of: openedx#1141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.