feat: Add support for design tokens #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xitij2000
force-pushed
the
kshitij/design-tokens
branch
3 times, most recently
from
d5462f3
to
a8ef5ae
Compare
xitij2000
force-pushed
the
kshitij/design-tokens
branch
2 times, most recently
from
2fbec38
to
ef5091d
Compare
|
@xitij2000 We should add some steps describing the process of updating the tokens and building the theme. |
This was referenced Dec 20, 2023
This change adds support for design tokens to simple theme.
xitij2000
force-pushed
the
kshitij/design-tokens
branch
from
ef5091d
to
03268f5
Compare
xitij2000
force-pushed
the
kshitij/design-tokens
branch
from
89f828a
to
9d3e0b2
Compare
|
|
||
| This is a two-step process: | ||
|
|
||
| 1. Building the tokens: The `paragon build-tokens` build tokens command compiles |
There was a problem hiding this comment.
Suggested change
| 1. Building the tokens: The `paragon build-tokens` build tokens command compiles | |
| 1. Building the tokens: The `npm build-tokens` build tokens command compiles |
There was a problem hiding this comment.
The command being the scenes is paragon. I'm just running it via npm scripts.
There was a problem hiding this comment.
@xitij2000 Yes, I know. People will need to use npm as they cannot directly run paragon commands which is why I am suggesting this change.
| the JSON style dictionaries into CSS file sin the `paragon/css/` directory. | ||
| These are supposed to be committed to the repository. | ||
| 2. Building the SCSS: The build token CSS files are then compiled into a brand | ||
| theme in the dist folder using the `paragon build-scss` command. The contents |
There was a problem hiding this comment.
Suggested change
| theme in the dist folder using the `paragon build-scss` command. The contents | |
| theme in the dist folder using the `npm build-scss` command. The contents |
Co-authored-by: Navin Karkera <[email protected]>
Co-authored-by: Navin Karkera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for design tokens to simple theme.