Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in-context discussion for units can be disabled by default #676

Conversation

kaustavb12
Copy link
Member

@kaustavb12 kaustavb12 commented Aug 31, 2024

Description

Currently for all new units which are added to a course, the discussions sidebar is enabled by default, which the course instructor can disable individually.

This PR, adds to the ability to disable discussions sidebar by default. That way all new units which are added will have the discussions sidebar disabled and can be individually enabled by the course instrutors.

Upstream PR : openedx#35414

Testing instructions

Part 1: Discussion Sidebar disable by default

  1. Check this sandbox has the correct edx-platform branch and has the UNIT_DISCUSSION_SIDEBAR_ENABLED_BY_DEFAULT flag set to false.
  2. Login to the sandbox https://lms.oc.eshe.opencraft.hosting/lms-login
  3. Go to Studio
  4. Create a new course, add a new unit and publish
  5. Wait for a minute and then check the live version in LMS
  6. Make sure the discussion sidebar is missing for this unit.
  7. In Studio enable discussion for this unit and wait for a minute.
  8. Go to LMS again and check that the discussions sidebar is now available.

Part 2: Discussion Sidebar enabled by default

  1. Check this sandbox has the correct edx-platform branch.
  2. Login to the sandbox https://lms.kaustav-two.eshe.opencraft.hosting/lms-login
  3. Go to Studio
  4. Create a new course, add a new unit and publish
  5. Wait for a minute and then check the live version in LMS
  6. Make sure the discussion sidebar is available for this unit.
  7. In Studio disable discussion for this unit and wait for a minute.
  8. Go to LMS again and check that the discussions sidebar is now available.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Private Ref : BB-9112

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would just like the name to be changed.

cms/envs/common.py Outdated Show resolved Hide resolved
@kaustavb12 kaustavb12 force-pushed the kaustav/disable_default_unit_discussion branch from 5efcd53 to 16e0009 Compare September 2, 2024 12:22
@kaustavb12 kaustavb12 force-pushed the kaustav/disable_default_unit_discussion branch from 16e0009 to 29a285b Compare September 2, 2024 12:32
@kaustavb12 kaustavb12 changed the title feat: vertical discussion sidedbar disable by default feat: in-context discussion for units can be disabled by default Sep 2, 2024
@kaustavb12 kaustavb12 merged commit 10aec43 into opencraft-release/redwood.1 Sep 2, 2024
77 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/disable_default_unit_discussion branch September 2, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants