Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to 'price' in ecommerce api loader #5

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: fallback to 'price' in ecommerce api loader #5

merged 3 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. chore: bump upload-artifact GH task to v4

    @tecoholic
    tecoholic committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d3f65a9 View commit details
    Browse the repository at this point in the history

  2. fix: fallback to 'price' in ecommerce api loader 

    The Django Oscar upgrade of ecommerce changed the
item's price field from `price_excl_tax` to just `price`
causing the EcommerceApi data loader to fail.

This commit checks for the `price_excl_tax` key and
falls back to the 'price' value.

Ref: openedx-unsupported/ecommerce#4050
    @tecoholic
    tecoholic committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c472007 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. refactor: apply review suggestion on fix

    @tecoholic
    tecoholic committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    198c47a View commit details
    Browse the repository at this point in the history