Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: The dataset_id is already part of the path here. #1851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dignfei
Copy link

@dignfei dignfei commented Jan 28, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.
The bug caused a runtime failure and prevented the correct retrieval of the data file's path.

Modification

Please briefly describe what modification is made in this PR.

fix the bug.The dataset_id is already part of the path here.

Checklist

Before PR:

  • [√ ] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [√ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ √] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ ]√ The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants