Set the severity annotation for non-OCM policies #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Gatekeeper is our current use-case, but I think this should be more generic, removing the fact that it's Gatekeeper and just setting the annotation if it's not OCM? It'd make the logic simpler and also prevent reverting this change if we ever add integrations for other policy engines. What do you think?
mprahl
changed the title
For policy-templates entries that are not OCM policies, it is supported to set the `policy.open-cluster-management.io/severity` annotation for other tooling to determine the severity of a noncompliant event. This adds that automatically. Relates: https://issues.redhat.com/browse/ACM-6860 Signed-off-by: mprahl <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fd7a535
into
open-cluster-management-io:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For policy-templates entries that are not OCM policies, it is supported to set the
policy.open-cluster-management.io/severityannotation for other tooling to determine the severity of a noncompliant event. This adds that automatically.Relates:
https://issues.redhat.com/browse/ACM-6860